sandialabs / pyGSTi

A python implementation of Gate Set Tomography
http://www.pygsti.info
Apache License 2.0
132 stars 55 forks source link

Tutorial updates #395

Closed sserita closed 5 months ago

sserita commented 5 months ago

This PR is only a partial completion of #317, but I'm including the current bugfixes in the next minor release because there is no reason to wait on all the updates and these include some high-visibility/-utility updates.

Included in this PR are the following items from #317:

This PR also fixes the following related issues:

sserita commented 5 months ago

Woot I think this is our first PR that is pulling in code owners outside of the dev team, which means that @coreyostrove you are off the hook (unless you also wanted to look).

@kmrudin and @pcwysoc: I know this is probably new for you. I'm happy to hop on a Teams call to help with the process. But the TL;DR is:

  1. Go over to the Files Changed tab.
  2. Any file with a blue shield in the top left is one that you are a code owner for. Look over the changes. Red is a removed line, green is an added line. For a changed line, you'll see a red followed immediately by a green, with the thing that is changed being highlighted.
  3. If you want to leave a comment, you can click on the line number and leave your comment.
  4. When you are done with a file, you can click on the Viewed box in the top right and move to the next one.
  5. When you have done all the files, click Review Changes in the top right above the files and either Approve if all looks good, Request changes if something looks bad, and Comment if you have questions but are not explicitly approving/rejecting.

If you come across a file that you are not a code owner for, feel free to skip it. If you come across a file that you ARE a code owner for and don't feel comfortable reviewing it, please comment that in the review - I can get someone else to review and then alter code owners appropriately.

@pcwysoc I think you are on this just for a single file, which might be the reports? In which case this should be a quick review for you 🤣

@kmrudin Unfortunately, Jupyter notebooks are particularly annoying to review here. For the typo updates, this should be relatively OK, but for the ModelNoise.ipynb and CustomMeasurement.ipynb, you may find it helpful to look at the tutorial notebooks here. For ModelNoise, the "Reduced error models" section is new, and the entire notebook is new for CustomMeasurement.