sandialabs / pyGSTi

A python implementation of Gate Set Tomography
http://www.pygsti.info
Apache License 2.0
136 stars 55 forks source link

Distinction between correlation error generators and active error generators in HTML reports #401

Open juangmendoza19 opened 9 months ago

juangmendoza19 commented 9 months ago

Is your feature request related to a problem? Please describe. While going through a HTML report I noticed that there is no way to tell which values correspond to active errors and which correspond to pauli correlation errors. They are both displayed as a triangle within a matrix, indexed by X,Y and Z. This is within "Gauge Dependent Error Metrics" > "Gate Error Generators".

Describe the solution you'd like Either add to the description above some indication of which triangle represents which error or get rid of the matrix and display them like the H and S generators.

coreyostrove commented 6 months ago

Here is my attempt at implementing this. Let me know what you think. There are also some changes I made to the error generator percentage labels, so feedback here is welcome too. updated_CA_plot

Note that I have also removed the spurious zeros along the diagonal (there are no diagonal C or A terms, and the inclusion of zeros gives the incorrect impression)

robinbk commented 6 months ago

I like Corey's implementation of the C/A division!

On Mon, May 6, 2024 at 6:00 PM coreyostrove @.***> wrote:

Here is my attempt at implementing this. Let me know what you think. There are also some changes I made to the error generator percentage labels, so feedback here is welcome too. updated_CA_plot.png (view on web) https://github.com/sandialabs/pyGSTi/assets/78768318/6b2ab079-2afb-411b-a472-22c62f444608

— Reply to this email directly, view it on GitHub https://github.com/sandialabs/pyGSTi/issues/401#issuecomment-2097169027, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACNUZ5JTK4ZWXNJQRFAELYTZBARUNAVCNFSM6AAAAABDABY3FOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAOJXGE3DSMBSG4 . You are receiving this because you are subscribed to this thread.Message ID: @.***>

juangmendoza19 commented 6 months ago

I love it!