search

sandialabs / pyGSTi

A python implementation of Gate Set Tomography
http://www.pygsti.info
Apache License 2.0
134 stars 56 forks source link

legacyio.py contains no executable code. #424

Closed rileyjmurray closed 2 weeks ago

rileyjmurray commented 5 months ago

All of the code in this file has been commented out. I suggest we delete the file.

https://github.com/sandialabs/pyGSTi/blob/ee2158575f4a6a9cffa7465983054be13772e0f8/pygsti/io/legacyio.py#L1-L385

sserita commented 5 months ago

Agreed. I think the next release we are anticipating is 0.9.13, which will have other deletions/deprecations (i.e. Qibo). So we can go ahead and delete this as part of that.

rileyjmurray commented 3 months ago

Note: At time of commenting, PR #451 includes an incidental change that would resolve this issue. However, I just opened PR #452 that's dedicated to the broader problem of removing commented-out code.

sserita commented 2 weeks ago

Closed with #451