sandialabs / pyGSTi

A python implementation of Gate Set Tomography
http://www.pygsti.info
Apache License 2.0
132 stars 55 forks source link

Remove commented-out function definitions and delete files with no executable code #452

Open rileyjmurray opened 1 month ago

rileyjmurray commented 1 month ago

NOTE: this is currently a draft PR. I'll convert it to a normal PR after my other PRs have been merged.

This PR aims to resolve #428. I'll note that some of my open PRs remove some of the same content removed here. I suspect Git will know how the reconcile the differences when those PRs are merged.

At time of opening this PR, the changes are quite likely over-zealous, so I'm happy to roll some changes back. That said, I suggest we be aggressive in removing this kind of unused text. Here's a proposal for how to decide what to actually keep and what to remove:

Another source of criteria for figuring out what to keep is to look for a short note at the beginning of some commented-out code block. Often there are notes that say "FUTURE," "Removed," "unused," "REMOVE," "Debugging," etc...

Other, miscellaneous changes