sandialabs / pyGSTi

A python implementation of Gate Set Tomography
http://www.pygsti.info
Apache License 2.0
132 stars 55 forks source link

Error gen projection basis must be Basis object #455

Open pcwysoc opened 2 weeks ago

pcwysoc commented 2 weeks ago

Describe the bug Error generator projections require a Basis object and do not work with a basis name, i.e. 'pp'. This is not the expect behavior as listed in the documentation. The issue appears to be with how the errorgen_and_projections function in reportables.py handles basis information.

Screenshot 2024-06-21 at 1 51 18 PM

Environment (please complete the following information):

sserita commented 2 weeks ago

This should be an easy fix, mx_basis needs a Basis.cast(mx_basis) prior accessing .name or something similar. We'll probs need to infer the dimension from the incoming errgen matrix.