sandialabs / pyapprox

Flexible and efficient tools for high-dimensional approximation, scientific machine learning and uncertainty quantification.
https://sandialabs.github.io/pyapprox/
MIT License
50 stars 13 forks source link

Fix barycentric interpolation on Windows #18

Open ConnectedSystems opened 3 years ago

ConnectedSystems commented 3 years ago

Many tests were failing on Windows due to a buffer dtype mismatch (cross-platform Cython issue, as discussed previously).

Addressed largely by specifying int type used in numpy arrays in inner functions (both in Python and Cython). I have kept fused type declaration as it is likely catching other use/edge cases.

On Windows, the number of failing tests have gone down from 44 to 22, none of which are related to buffer mismatches. No buffer mismatch errors are raised when running tests on Ubuntu 20.04 (although 15 do fail).

I am assuming the failing tests cover pieces of work still in progress.