search

sandialabs / pyscan

Scientific Measurement Toolbox
https://pyscan.readthedocs.io/en/latest/
MIT License
4 stars 4 forks source link

Reg pip install workflow #216

Closed rsbrost closed 1 month ago

rsbrost commented 2 months ago
  1. This includes changes from the remove-legacy-notebooks branch, which should be pulled first to isolate the workflow changes on this branch.
  2. Furthermore, Jasmine's fixes need to be incorporated for it to pass the complete2 job (workflow added in this branch and PR).
  3. Lastly, the complete2 job should be added to the repository main branch protection settings as a required check. We could consider renaming the first complete workflow to complete1, which would also need to be refactored in the branch protection rule on the github settings. Obviously make sure the complete2 workflow (which uses pip install . without the -e) is passing before pulling.
rsbrost commented 2 months ago

Jasmine's fix incorporated/improved upon. Will now work with regular pip install omitting the -e

rsbrost commented 1 month ago

This has now been addressed. Please remember to make the job "complete2" a required status check in the main branches branch protection rules.