search

sandialabs / pyscan

Scientific Measurement Toolbox
https://pyscan.readthedocs.io/en/latest/
MIT License
4 stars 4 forks source link

Stanford 830 snap() bug #217

Closed mplilly4395 closed 2 weeks ago

mplilly4395 commented 2 months ago

The SRS830 method snap() and snap_xy() requires a string of indices for arguments. The string for the SCPI command has a bug when making the indices. Integers cannot be joined into a string.

The change needed (on line 593) is to make the list of indices strings rather than integers:

currently: indicies = [sources.index(arg) + 1 for arg in args]

corrected: indicies = [str(sources.index(arg) + 1) for arg in args]

I can open a pull request with this change, but I know there is a branch specifically for the stanford 830.

mplilly4395 commented 2 months ago

Jasmine, let me know if you want to include this in your branch, or if I should just submit a short fix for this.

plesiopterys commented 2 months ago

Sure I can implement this

plesiopterys commented 2 months ago

Nevermind, it looks like it's already implemented on the branch