sandialabs / pyttb

Python Tensor Toolbox
https://pyttb.readthedocs.io
BSD 2-Clause "Simplified" License
25 stars 13 forks source link

Replace pylint and isort with ruff #210

Closed ntjohnson1 closed 1 year ago

ntjohnson1 commented 1 year ago

Right now pylint takes ~1 minute to run. That's not terribly painful, since it does catch a lot of things. However, much of the community is moving towards ruff and it appears to capture MOST if not all the details of pylint (especially when combined with our typing support). Ruff runs in <1s on our code base so we could swap this in for our pre-commit hook. Ruff also covers isort rules and with its --fix option will automatically fix the things isort covers.

For context ALL of our tests right now take ~5s to run on my machine. So reducing the linting step to be on the same order of magnitude of everything else will at least improve my dev iteration speed.