Feedback fixes

[ntjohnson1]

This is a combination of a variety of pieces. If there is anything that needs more discussion I can separate into a different branch/PR and we can land everything else.

Resolves:

• https://github.com/sandialabs/pyttb/issues/223
  • Delete makefile
  • Add details on pypi and installing from source on README, and documentation landing page
  • Update contributing doc with more details about building our documentation/tutorials
• https://github.com/sandialabs/pyttb/issues/225
  • Set flag based on threshold value and update default
• https://github.com/sandialabs/pyttb/issues/227
  • More elaboration in the issue
• https://github.com/sandialabs/pyttb/issues/228
  • Updated tutorials based on recommendations with elaboration on the issue

Some other niceties:

• Cleaned up some warnings that were printing when we run pytest.
• While reviewing the tutorials I noticed we had some code lines that were too long which introduced horizontal scroll bars. I enabled black to run on our notebooks to solve this issue automatically moving forward.
• As a follow up to https://github.com/sandialabs/pyttb/issues/224 I added a github action that should verify the links in our markdown moving forward. There is a python tool that would have been nice to use since it runs locally as well, however it had some false positives I couldn't easily adjust around.

---

:books: Documentation preview :books:: https://pyttb--229.org.readthedocs.build/en/229/

[ntjohnson1]

FYI @dmdunla I wasn't able to add @jeremy-myers as a reviewer so it might make sense to check his permissions. Otherwise I tagged him here as a heads up to see if there is anything I misinterpreted of forgot to resolve for the issues raised.

[jeremy-myers]

@ntjohnson1 I just accepted @dmdunla 's invitation; try adding me for review again.

[dmdunla]

@jeremy-myers when you do get a chance to review, please just re use and do not merge. I’ll merge once the reviews are complete.

---

From: Jeremy Myers @.> Sent: Sunday, September 10, 2023 12:00:04 PM To: sandialabs/pyttb @.> Cc: Dunlavy, Danny @.>; Mention @.> Subject: [EXTERNAL] Re: [sandialabs/pyttb] Feedback fixes (PR #229)

@ntjohnson1https://github.com/ntjohnson1 I just accepted @dmdunlahttps://github.com/dmdunla 's invitation; try adding me for review again.

— Reply to this email directly, view it on GitHubhttps://github.com/sandialabs/pyttb/pull/229#issuecomment-1712898138, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AHIY2IVNXMQMZEOMT5BW3G3XZX52JANCNFSM6AAAAAA4QMZLJQ. You are receiving this because you were mentioned.Message ID: @.***>