sandialabs / qthreads

Lightweight locality-aware user-level threading runtime.
https://www.sandia.gov/qthreads/
Other
173 stars 35 forks source link

Race Condition in Shepherd Management Code #223

Closed insertinterestingnamehere closed 9 months ago

insertinterestingnamehere commented 9 months ago

There's an additional data race in the shepherd management code that shows up in the disable_shepherd test.

Atomic write: https://github.com/sandialabs/qthreads/blob/55ad590801b7188aa5f0e34a8946260a2726046c/src/shepherds.c#L178 Non-atomic read: https://github.com/sandialabs/qthreads/blob/55ad590801b7188aa5f0e34a8946260a2726046c/src/qthread.c#L474.