sandialabs / qthreads

Lightweight locality-aware user-level threading runtime.
https://www.sandia.gov/qthreads/
Other
173 stars 35 forks source link

Remove Our Own Implementations of Atomic Operations #225

Closed insertinterestingnamehere closed 1 month ago

insertinterestingnamehere commented 9 months ago

We have a ton of internal implementations of various atomic operations that use either the old __sync gcc intrinsics or just use assembly directly. Given that we already require C11 atomics it'd be good to get rid of these things entirely to reduce the maintenance burden.

insertinterestingnamehere commented 1 month ago

https://github.com/sandialabs/qthreads/pull/286 got rid of the assembly atomics at least. I'm fine with leaving the __sync atomics as-is for now, though we should probably deal with those eventually too.