search

sandialabs / qthreads

Lightweight locality-aware user-level threading runtime.
https://www.sandia.gov/qthreads/
Other
173 stars 35 forks source link

Adjust FEB Fences #250

Closed insertinterestingnamehere closed 7 months ago

insertinterestingnamehere commented 8 months ago

Careful review appreciated for this one in particular.

This changes the implementation of FEBs so that a memory fence occurs even when the output value passed to the FEB routine is null. This matters because prior to this change, there's not necessarily a guaranteed fence implied by calls like readFF and the tests frequently use readFF to decide that it's safe to read some value that may be completely distinct from the FEB that's been marked as full.

insertinterestingnamehere commented 7 months ago

@olivier-snl @janciesko This one's settled on my end now. I'd definitely still appreciate closer review on it though.