sandialabs / qthreads

Lightweight locality-aware user-level threading runtime.
https://www.sandia.gov/qthreads/
Other
173 stars 35 forks source link

Nemesis Cacheline Adjustment #257

Closed insertinterestingnamehere closed 1 month ago

insertinterestingnamehere commented 1 month ago

Okay, testing this with the threadring benchmark on several different test machines shows that this does give a very small but consistent performance improvement so I'm inclined to go ahead with it.

janciesko commented 1 month ago

Testing on M1

insertinterestingnamehere commented 1 month ago

This either results in a very slight improvement or not change in performance on all systems tested. The only caveat is that the cacheline size needs to be set correctly, otherwise performance is wildly inconsistent with or without this patch.