Closed GhostofGoes closed 11 months ago
This is complete and ready to merge once reviewed.
I'm not familiar enough with the sceptre app to provide an adequate review.
@GhostofGoes perhaps you can request a review from someone you know is familiar with the app?
@mgaliar I think would be able to review it. I don't think I have the permissions required to request reviews through GitHub.
I won't be able to take a look until 10/3 at the earliest. If @c-abate has time he can probably take a look :). Otherwise, I will look at it then.
I've reviewed and approved, but I can't merge until @mgaliar approves as well
Summary
This PR consists of changes to the sceptre app, including a new infrastructure and several Simulink-related enhancements.
Changes
.editorconfig
. Any editors that support it, such as VSCode with an extension, will ensure correct formatting for the project.BatteryInfrastructure
classInfrastructure.factory()
BatteryInfrastructure
gt
andgt_template
are no longer required for provider metadata. This hasn't been maintained in a while according a SCEPTRE expert. They'll still be used if present, but they're no longer required to be there.publish_endpoint
to be set for Simulink provider. If unspecified, it'll be set to a default value ofudp://*;239.0.0.1:40000
. Virtually every topology has the same value forpublish_endpoint
. This should be able to be changed if needed, but it shouldn't be required, as it's just unnecessary boilerplate. If it's configured, use the value, if not, default to the UDP multicast address and port 40000.