Closed jacdavi closed 1 year ago
Thanks @jacdavi for the contribution! I'll take a look at this ASAP and let you know if I have any questions or concerns.
Sounds good and no rush! I'm pretty new to both Go and Vue, so I expect there's a number of things to be improved (some of which I'm aware of, but haven't come back to yet) :)
@jacdavi you mind if I force push to your branch for this PR? I rebased and fixed some conflicts.
@jacdavi you mind if I force push to your branch for this PR? I rebased and fixed some conflicts.
Go for it!
@jacdavi I still need to do some testing when authentication is enabled and when we're accessing phenix on a URL path that isn't /
. More to come.
@jacdavi I did some additional testing with auth enabled and on a URL path that isn't / and everything seemed to work as expected. As such, I think I'm ready to squash and merge this in. Let me know what you think.
Very similar to what's provided in miniweb, this adds a top-level tab that will allow interacting with the minimega console. The goal is to allow users to accomplish low-level tasks in phenix which do not otherwise have explicit support. Currently only phenix global admins can access the console.
The terminal will dynamically resize (in general, any use of Terminal can be resized if the prop is set specifying the endpoint).
A new CLI argument (minimega-path) must be set for the console to function. The minimega Docker image has been updated to make a copy of the minimega executable available at /tmp/minimega/bin/minimega. If the Docker Compose file provided is being used to deploy minimega and phenix, this means users can pass the
--minimega-path=/tmp/minimega/bin/minimega
flag to thephenix ui
command when starting the UI process to make the minimega console available.