search

sandialabs / sceptre-phenix

phenix is an orchestration tool and GUI for Sandia's minimega platform
https://sandialabs.github.io/sceptre-docs/
GNU General Public License v3.0
17 stars 23 forks source link

update noVNC to 1.3.0 #115

Closed jacdavi closed 1 year ago

jacdavi commented 1 year ago

Updates noVNC to 1.3.0 to match recent minimega update

I think I updated everything phenix specific (e.g., page banner and title). Did noVNC ever work when running the dev webserver (npm run serve)?

activeshadow commented 1 year ago

@jacdavi did you happen to test the VM banner capability with this branch yet?

jacdavi commented 1 year ago

@jacdavi did you happen to test the VM banner capability with this branch yet?

Yeah, I did confirm that the banner still shows. It's not readable for the first second since noVNC displays a toast about connecting to the VM, but that's probably not a big enough deal to worry about.

activeshadow commented 1 year ago

@jacdavi the only issue I see with banners is that the top one is allowed to be scrolled away in some instances.

activeshadow commented 1 year ago

@jacdavi the only issue I see with banners is that the top one is allowed to be scrolled away in some instances.

@jacdavi I found a fix so I'll add it in and then merge this. Thank you!

jacdavi commented 1 year ago

Thanks @activeshadow !