search

sandialabs / sceptre-phenix

phenix is an orchestration tool and GUI for Sandia's minimega platform
https://sandialabs.github.io/sceptre-docs/
GNU General Public License v3.0
19 stars 25 forks source link

Record basic information as artifact for each SCORCH run #129

Closed activeshadow closed 1 year ago

activeshadow commented 1 year ago

Each scorch run creates a /phenix/images/{{BRANCH_NAME}}/files/scorch/run-#/info-scorch-run#_time.txt file which records basic information about the scorch run, including: Experiment Name, Scorch Run Name, Scorch Run Start Time, Scorch Run Stop Time, Phenix Version, Minimega Version.

activeshadow commented 1 year ago

@nblair2 looks good! Do you mind moving the code you added to a separate function named something like recordInfo so we can keep it as a separate unit of code?

I'll have some additional suggestions once it's moved.

Thanks for this!

nblair2 commented 1 year ago

@activeshadow refactored - please take a look and let me know if I am using too many args for the function.

nblair2 commented 1 year ago

@activeshadow - I appreciate the pointers. Changes made.

activeshadow commented 1 year ago

Closing this so @nblair2 can open a new PR for this himself.