Closed glattercj closed 7 months ago
Please do not merge until I can rebase and squash these commits and update the commit message.
@glattercj I've updated some of the code to achieve the following:
- Move the
--unix-socket-endpoint
option for theui
subcommand to now be a root--unix-socket
option that is used by the UI to run a HTTP server at the path provided and by the CLI to attempt to connect to the HTTP server at the path provided. Previously, the UI would only start a HTTP server on the Unix socket if set explicitly. Now it will do so by default since a default path is provided.- Moved the
--deploy-mode
option from theui
subcommand to be a root option that is used by either the UI server or any of the CLI subcommands. Most notably, theexp create
subcommand. This deviates from what you had done in that it's used when creating an experiment instead of when starting/restarting one.- If the CLI is able to connect to the UI server to get the
deploy-mode
option set when the UI was started, it will use that as the default deploy mode for any CLI subcommands unless the root--deploy-mode
option is passed to the CLI command.- In any case, if the
--deploy-mode
is not provided to the UI server and is not provided to the CLI, it will default to the traditionalno-headnode
mode.- Added an option for setting the deploy mode to the UI modal for creating an experiment. If left unset, it will default to whatever the default mode is for the UI.
- Added an option for setting the deploy mode in the git workflow. The key is
deployMode
and is at the same level astopology
,scenario
, etc. If left unset, it will default to whatever the default mode is for the UI.Thoughts?
LGTM
runLocal
option from experiment specdeploy-mode
CLI and UI option forexperiment start...
.all | no-headnode | only-headnode
, with default=no-headnode.ns hosts
list for the experiment namespaceall
- addslocalhost
to the namespace ns hosts listno-headnode
- default behavior; no changes to minimega script; uses mesh nodes as ns hosts listonly-headnode
- removes all mesh nodes from ns hosts list and addslocalhost
onlyCLI example:
UI example: