search

sandialabs / sceptre-phenix

phenix is an orchestration tool and GUI for Sandia's minimega platform
https://sandialabs.github.io/sceptre-docs/
GNU General Public License v3.0
17 stars 23 forks source link

feat: add disk space to hosts tab in phenix ui #172

Closed glattercj closed 4 months ago

glattercj commented 7 months ago

Add disk space % to Hosts tab in phenix UI - uses df on common.PhenixBase and common.MinimegaBase.

Screenshot 2024-02-08 at 21 46 00
activeshadow commented 6 months ago

@glattercj can you revert all of the this --> m changes that you made in this PR please?

glattercj commented 6 months ago

@glattercj can you revert all of the this --> m changes that you made in this PR please?

Sure. I thought it was more ideomatic to not use the this keyword in Golang.

activeshadow commented 6 months ago

@glattercj can you revert all of the this --> m changes that you made in this PR please?

Sure. I thought it was more ideomatic to not use the this keyword in Golang.

@glattercj it is... but I use this exclusively within the phēnix code base. It's pretty much the only idiomatic rule I don't follow. :joy:

glattercj commented 6 months ago

@glattercj can you revert all of the this --> m changes that you made in this PR please?

Sure. I thought it was more ideomatic to not use the this keyword in Golang.

@glattercj it is... but I use this exclusively within the phēnix code base. It's pretty much the only idiomatic rule I don't follow. 😂

Done...smh

glattercj commented 4 months ago

@activeshadow Tested with single and multi-node - g2g.