search

sandialabs / sceptre-phenix

phenix is an orchestration tool and GUI for Sandia's minimega platform
https://sandialabs.github.io/sceptre-docs/
GNU General Public License v3.0
17 stars 23 forks source link

fix: remove colons from filenames output by scorch #188

Closed nblair2 closed 1 month ago

nblair2 commented 2 months ago

Currently, scorch archive and info files are created using the start time in RFC3339 format, which includes colons. This causes issues with some OSes, where colons in filenames are not expected (ex. running tar xzfv scorch-run-1_2024-07-03T23:02:41Z.tgz will throw an error on linux systems).

All Golang time.Format pre-defined layouts that include times also include colons, so this fix uses a custom format 2006-01-02T15-04-05Z0700.

Alternatively strings.ReplaceAll(startTime.Format(time.RFC3339, ":", "=") could be used.

GhostofGoes commented 2 months ago

Thanks for fixing this! This was an issue I ran into doing some experiments a few months ago, it make it difficult to share experiment data with collaborators on Windows systems (and harder for me to process and share the data).