search

sandialabs / sceptre-phenix

phenix is an orchestration tool and GUI for Sandia's minimega platform
https://sandialabs.github.io/sceptre-docs/
GNU General Public License v3.0
17 stars 23 forks source link

Delete phenix VM injection snapshots when an experiment is stopped #22

Open activeshadow opened 3 years ago

activeshadow commented 3 years ago

Originally created by @activeshadow on Thu, 18 Feb 2021 17:03:55 GMT

Right now, we only delete experiment VM injection snapshots right before an experiment is started and when an experiment is deleted. We don't currently delete them when an experiment is stopped just in case we need to pull an injection out, confirm an injection was added, etc. (essentially for debugging purposes).

I propose we change to deleting the injection snapshots by default when an experiment is stopped and add a flag to the experiment stop command to keep the injection snapshots around if necessary.

activeshadow commented 2 years ago

How would we handle this in the UI? Add a modal that asks the question?