search

sandialabs / seacas

The Sandia Engineering Analysis Code Access System (SEACAS) is a suite of preprocessing, postprocessing, translation, and utility applications supporting finite element analysis software using the Exodus database file format.
Other
132 stars 79 forks source link

Ioss includes own headers with `<>` #415

Closed mathstuf closed 5 months ago

mathstuf commented 10 months ago

This requires that an explicit -I be passed for the headers to find each other. It would be better if the library could include its own headers using "" paths relative to the header itself.

gsjaardema commented 10 months ago

Yes, that is probably a good idea. At one time, we had a build system where the <> includes were required or strongly recommended, but that is no longer being used and the current includes use a mismash of "" and <>. Would be good to be consistent and probably consistently use ""

gsjaardema commented 9 months ago

Does #423 address this issue. It has been merged.

mathstuf commented 9 months ago

Looks OK to me; I'll be back if we find an issue (next time we bump IOSS). I'll leave you to close according to your workflow.