search

sandialabs / seacas

The Sandia Engineering Analysis Code Access System (SEACAS) is a suite of preprocessing, postprocessing, translation, and utility applications supporting finite element analysis software using the Exodus database file format.
Other
131 stars 79 forks source link

Ioss related fixes #436

Closed spyridon97 closed 7 months ago

spyridon97 commented 7 months ago

Ioss related fixes

spyridon97 commented 7 months ago

@gsjaardema these are the fixes that i found.

gsjaardema commented 7 months ago

Thanks.

gsjaardema commented 7 months ago

Are you using c++17, or an earlier version? Or, in other words, does the IOSS_MAYBE_UNUSED macro work for your builds, or do you require the IOSS_PAR_UNUSED(var) to eliminate unused variable warnings?

gsjaardema commented 7 months ago

The reason for the previous question is that we are still getting the unused variable warnings even with the chagnes in 86d7223, but they go away if I switch to using IOSS_MAYBE_UNUSED