search

sandialabs / seacas

The Sandia Engineering Analysis Code Access System (SEACAS) is a suite of preprocessing, postprocessing, translation, and utility applications supporting finite element analysis software using the Exodus database file format.
Other
131 stars 79 forks source link

fix: include fmt/ranges.h in Ioss_Decomposition.C, Ioss_ParallelUtils.h (fmt-11) #477

Closed wdconinc closed 1 month ago

wdconinc commented 1 month ago

fmt v11 (release notes) "moved range and iterator overloads of fmt::join to fmt/ranges.h, next to other overloads."

This means the fmt::join in Ioss_Decompoition.C is not found: https://github.com/sandialabs/seacas/blob/049a054ee0e1c1107336d5996136314f57ddbe2a/packages/seacas/libraries/ioss/src/Ioss_Decomposition.C#L87

This PR adds the necessary fmt/ranges.h includes in that and one other place (behind a DEBUG define).

A possible other location that needs adapting (but I was unable to verify) is https://github.com/sandialabs/seacas/blob/049a054ee0e1c1107336d5996136314f57ddbe2a/packages/seacas/libraries/aprepro_lib/aprepro.ll#L154

This change should not have negative effects for older versions of fmt.