search

sandialabs / seat-qgis-plugin

Spatial Environmental Assessment Toolkit (SEAT) QGIS Plugin
https://sandialabs.github.io/seat-qgis-plugin/
GNU General Public License v3.0
1 stars 7 forks source link

Bug fix to seat code and additional documentation #12

Closed tnelson-integral closed 1 year ago

tnelson-integral commented 1 year ago

This code fixes a few bugs identified in .tif generations for classified output and adds output. Documentation was added for a tutorial and overview, however I am having difficulty generating a new index. -Tim

ssolson commented 1 year ago

@tnelson-integral I see you marked this PR as a draft but also tagged me for a review.

Is this PR ready for review or are you still working on it?

image

tnelson-integral commented 1 year ago

@ssolson, it is ready for review, I am aware of some errors regarding the documentation formatting that I could use your revisions on. Let me know if I need to change the status of this request for that to happen.

ssolson commented 1 year ago

Okay Thanks Tim!

I took a look at this last night and I saw nothing that prevent moving this forward. I will go through it one more time and get it merged today.

Going forward we should talk strategy for working together. For example breaking this PR into 2 PRs: 1 for the bug fix and 1 for the documentation (this streamlines the review process). And then on the documentation we should coordinate because I have an open PR. The idea would be to both work on the same branch or coordinate specific sections to work on so that there is not rework and work that gets deprecated from moving things around ect. I can merge our work together no problem this time but PR #11 I had already changed some of the files that you also changed and our coordination will reduce this rework and work to then pick which version of the file is the final.

ssolson commented 1 year ago

@tnelson-integral

I took care of all the changes above here https://github.com/ssolson/seat-qgis-plugin/pull/2

This PR is now included in #11