search

sandialabs / seat-qgis-plugin

Spatial Environmental Assessment Toolkit (SEAT) QGIS Plugin
https://sandialabs.github.io/seat-qgis-plugin/
GNU General Public License v3.0
1 stars 7 forks source link

Acoustics module update #34

Open tnelson-integral opened 2 months ago

tnelson-integral commented 2 months ago

Start of Acoustics Module update for weighting and exposure level.

tnelson-integral commented 2 months ago

Just starting this. Still have work to do on updating the calculations, but this will be the next large update.

tnelson-integral commented 1 week ago

@ssolson Ashley is continuing to update the documents for the Acoustics section, however the code is ready for review.

ssolson commented 1 week ago

Thanks for the heads up @tnelson-integral . Before we review you need to merge the main branch into this branch so everything is up to date. Currently this branch conflicts with the main. After merging most likely you will need to make changes to ensure we are passing tests. Lastly it would be best to add Acoustics modules tests before merging if we are not on a short time turn around for this.

tnelson-integral commented 3 days ago

All but 1 linting issue fixed. I need to figure out how to remove or merge 2 more defs.

ssolson commented 10 hours ago

Great job Tim 🎉! I'll start reviewing.

tnelson-integral commented 8 hours ago

Hi Sterling, It is possible I might have broken a few things while getting it formatted (Hopefully not though). I plan to look at this again Tuesday. If you haven't started yet, hold off, and I will let you know once I have verified everything still works. -Thanks, -Tim

Tim Nelson (he/him/his) | Project Scientist Tel: 561.240.5096 | Cell: 803.319.3344 | St. Petersburg | FL @.*** | Biohttps://www.integral-corp.com/staff/timothy-r-nelson-ph-d

https://www.integral-corp.com/[cid:integral_1a04a855-2877-4c4f-bd98-b89de3950d0f.png]https://www.integral-corp.com/

From: ssolson @.> Sent: Monday, September 16, 2024 11:56 AM To: sandialabs/seat-qgis-plugin @.> Cc: Tim Nelson @.>; Mention @.> Subject: Re: [sandialabs/seat-qgis-plugin] Acoustics module update (PR #34)

[CAUTION: External email. Think before you click links or open attachments.]

Great job Tim 🎉! I'll start reviewing.

— Reply to this email directly, view it on GitHubhttps://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_sandialabs_seat-2Dqgis-2Dplugin_pull_34-23issuecomment-2D2353310927&d=DwMFaQ&c=euGZstcaTDllvimEN8b7jXrwqOf-v5A_CdpgnVfiiMM&r=2OT5Kb-Guh1vdHPYH_OKgQqqKZs-WcstcKgpghDlHN8&m=tqlGmmd8SaD4ZxlV1H2Iu-CEmR7hobvLtCU1bjRy2e_Xx8gmee1jwi7FCP9DCatw&s=2dvP_0fuftUe8o7j43OnWXJxlP_gnKP-_YrDegCYBjQ&e=, or unsubscribehttps://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_notifications_unsubscribe-2Dauth_AZARDBI7AJHBAQWZZMT4EB3ZW35TRAVCNFSM6AAAAABJ6TD5U2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGNJTGMYTAOJSG4&d=DwMFaQ&c=euGZstcaTDllvimEN8b7jXrwqOf-v5A_CdpgnVfiiMM&r=2OT5Kb-Guh1vdHPYH_OKgQqqKZs-WcstcKgpghDlHN8&m=tqlGmmd8SaD4ZxlV1H2Iu-CEmR7hobvLtCU1bjRy2e_Xx8gmee1jwi7FCP9DCatw&s=0l2deISz6A95BrtHvV-ODpK-7NtOMPh8D-TgGpUsZyg&e=. You are receiving this because you were mentioned.Message ID: @.***>