search

sandiz / rs-manager

Stats Manager for Rocksmith - Manage Playlists, Stats, Setlists and more!
https://sandiz.github.io/rs-manager/
GNU General Public License v3.0
52 stars 8 forks source link

Getting a crash when clicking on a song in Detail View #71

Closed JustinAiken closed 5 years ago

JustinAiken commented 5 years ago

Describe the bug Click on an individual arrangement starts to pop up the detail modal, then it crashes

To Reproduce

Expected behavior Something should pop up

Screenshots Screen Shot 2019-05-31 at 4 46 53 PM

or in text form:

searching for  Ain't No Sunshine Bill Withers rocksmith Ain't No Sunshine Bill Withers music video
react-dom.production.min.js:3744 TypeError: Cannot read property 'length' of undefined
    at t.a.render (songdetailView.js:334)
    at Ki (react-dom.production.min.js:3357)
    at Zi (react-dom.production.min.js:3348)
    at eo (react-dom.production.min.js:3507)
    at Ao (react-dom.production.min.js:4486)
    at Mo (react-dom.production.min.js:4505)
    at pa (react-dom.production.min.js:4826)
    at ca (react-dom.production.min.js:4800)
    at Ro (react-dom.production.min.js:4681)
    at Object.enqueueSetState (react-dom.production.min.js:2796)
    at t.y.setState (react.production.min.js:71)
    at t.<anonymous> (songdetailView.js:128)
    at _ (runtime.js:63)
    at Generator._invoke (runtime.js:282)
    at Generator.e.(anonymous function) [as next] (file:///Applications/Rocksmith%20Manager.app/Contents/Resources/app/build/static/js/3.7a7b0af6.chunk.js:1:854092)
    at r (asyncToGenerator.js:3)
    at s (asyncToGenerator.js:25)
    at process._tickCallback (internal/process/next_tick.js:68)
oo @ react-dom.production.min.js:3744
n.callback @ react-dom.production.min.js:4018
ii @ react-dom.production.min.js:2666
ri @ react-dom.production.min.js:2654
ha @ react-dom.production.min.js:5090
pa @ react-dom.production.min.js:4826
ca @ react-dom.production.min.js:4800
Ro @ react-dom.production.min.js:4681
enqueueSetState @ react-dom.production.min.js:2796
y.setState @ react.production.min.js:71
(anonymous) @ songdetailView.js:128
_ @ runtime.js:63
(anonymous) @ runtime.js:282
e.(anonymous function) @ runtime.js:116
r @ asyncToGenerator.js:3
s @ asyncToGenerator.js:25
_tickCallback @ internal/process/next_tick.js:68
Promise.then (async)
r @ asyncToGenerator.js:13
s @ asyncToGenerator.js:25
(anonymous) @ asyncToGenerator.js:32
(anonymous) @ asyncToGenerator.js:21
(anonymous) @ songdetailView.js:63
(anonymous) @ songdetailView.js:98
_ @ runtime.js:63
(anonymous) @ runtime.js:282
e.(anonymous function) @ runtime.js:116
r @ asyncToGenerator.js:3
s @ asyncToGenerator.js:25
(anonymous) @ asyncToGenerator.js:32
(anonymous) @ asyncToGenerator.js:21
(anonymous) @ songdetailView.js:63
Ci @ react-dom.production.min.js:2823
Zi @ react-dom.production.min.js:3347
eo @ react-dom.production.min.js:3507
Ao @ react-dom.production.min.js:4486
Mo @ react-dom.production.min.js:4505
pa @ react-dom.production.min.js:4826
ca @ react-dom.production.min.js:4800
va @ react-dom.production.min.js:5202
On @ react-dom.production.min.js:1737
songdetailView.js:149 Uncaught (in promise) TypeError: Cannot read property 'length' of undefined
    at t.<anonymous> (songdetailView.js:149)
    at _ (runtime.js:63)
    at Generator._invoke (runtime.js:282)
    at Generator.e.(anonymous function) [as next] (file:///Applications/Rocksmith%20Manager.app/Contents/Resources/app/build/static/js/3.7a7b0af6.chunk.js:1:854092)
    at r (asyncToGenerator.js:3)
    at s (asyncToGenerator.js:25)
    at asyncToGenerator.js:32
    at new Promise (<anonymous>)
    at t.<anonymous> (asyncToGenerator.js:21)
    at t.chooseVideo (songdetailView.js:63)
    at t.<anonymous> (songdetailView.js:138)
    at ii (react-dom.production.min.js:2666)
    at ri (react-dom.production.min.js:2652)
    at ha (react-dom.production.min.js:5073)
    at pa (react-dom.production.min.js:4826)
    at ca (react-dom.production.min.js:4800)
    at Ro (react-dom.production.min.js:4681)
    at Object.enqueueSetState (react-dom.production.min.js:2796)
    at t.y.setState (react.production.min.js:71)
    at t.<anonymous> (songdetailView.js:135)
    at _ (runtime.js:63)
    at Generator._invoke (runtime.js:282)
(anonymous) @ songdetailView.js:149
_ @ runtime.js:63
(anonymous) @ runtime.js:282
e.(anonymous function) @ runtime.js:116
r @ asyncToGenerator.js:3
s @ asyncToGenerator.js:25
(anonymous) @ asyncToGenerator.js:32
(anonymous) @ asyncToGenerator.js:21
(anonymous) @ songdetailView.js:63
(anonymous) @ songdetailView.js:138
ii @ react-dom.production.min.js:2666
ri @ react-dom.production.min.js:2652
ha @ react-dom.production.min.js:5073
pa @ react-dom.production.min.js:4826
ca @ react-dom.production.min.js:4800
Ro @ react-dom.production.min.js:4681
enqueueSetState @ react-dom.production.min.js:2796
y.setState @ react.production.min.js:71
(anonymous) @ songdetailView.js:135
_ @ runtime.js:63
(anonymous) @ runtime.js:282
e.(anonymous function) @ runtime.js:116
r @ asyncToGenerator.js:3
s @ asyncToGenerator.js:25
_tickCallback @ internal/process/next_tick.js:68
Promise.then (async)
r @ asyncToGenerator.js:13
s @ asyncToGenerator.js:25
(anonymous) @ asyncToGenerator.js:32
(anonymous) @ asyncToGenerator.js:21
(anonymous) @ songdetailView.js:63
(anonymous) @ songdetailView.js:99
_ @ runtime.js:63
(anonymous) @ runtime.js:282
e.(anonymous function) @ runtime.js:116
r @ asyncToGenerator.js:3
s @ asyncToGenerator.js:25
(anonymous) @ asyncToGenerator.js:32
(anonymous) @ asyncToGenerator.js:21
(anonymous) @ songdetailView.js:63
Ci @ react-dom.production.min.js:2823
Zi @ react-dom.production.min.js:3347
eo @ react-dom.production.min.js:3507
Ao @ react-dom.production.min.js:4486
Mo @ react-dom.production.min.js:4505
pa @ react-dom.production.min.js:4826
ca @ react-dom.production.min.js:4800
va @ react-dom.production.min.js:5202
On @ react-dom.production.min.js:1737
asyncToGenerator.js:6 Uncaught (in promise) TypeError: Cannot read property 'length' of undefined
    at t.a.render (songdetailView.js:334)
    at Ki (react-dom.production.min.js:3357)
    at Zi (react-dom.production.min.js:3348)
    at eo (react-dom.production.min.js:3507)
    at Ao (react-dom.production.min.js:4486)
    at Mo (react-dom.production.min.js:4505)
    at pa (react-dom.production.min.js:4826)
    at ca (react-dom.production.min.js:4800)
    at Ro (react-dom.production.min.js:4681)
    at Object.enqueueSetState (react-dom.production.min.js:2796)
    at t.y.setState (react.production.min.js:71)
    at t.<anonymous> (songdetailView.js:128)
    at _ (runtime.js:63)
    at Generator._invoke (runtime.js:282)
    at Generator.e.(anonymous function) [as next] (file:///Applications/Rocksmith%20Manager.app/Contents/Resources/app/build/static/js/3.7a7b0af6.chunk.js:1:854092)
    at r (asyncToGenerator.js:3)
    at s (asyncToGenerator.js:25)
    at process._tickCallback (internal/process/next_tick.js:68)
a.render @ songdetailView.js:334
Ki @ react-dom.production.min.js:3357
Zi @ react-dom.production.min.js:3348
eo @ react-dom.production.min.js:3507
Ao @ react-dom.production.min.js:4486
Mo @ react-dom.production.min.js:4505
pa @ react-dom.production.min.js:4826
ca @ react-dom.production.min.js:4800
Ro @ react-dom.production.min.js:4681
enqueueSetState @ react-dom.production.min.js:2796
y.setState @ react.production.min.js:71
(anonymous) @ songdetailView.js:128
_ @ runtime.js:63
(anonymous) @ runtime.js:282
e.(anonymous function) @ runtime.js:116
r @ asyncToGenerator.js:3
s @ asyncToGenerator.js:25
_tickCallback @ internal/process/next_tick.js:68
Promise.then (async)
r @ asyncToGenerator.js:13
s @ asyncToGenerator.js:25
(anonymous) @ asyncToGenerator.js:32
(anonymous) @ asyncToGenerator.js:21
(anonymous) @ songdetailView.js:63
(anonymous) @ songdetailView.js:98
_ @ runtime.js:63
(anonymous) @ runtime.js:282
e.(anonymous function) @ runtime.js:116
r @ asyncToGenerator.js:3
s @ asyncToGenerator.js:25
(anonymous) @ asyncToGenerator.js:32
(anonymous) @ asyncToGenerator.js:21
(anonymous) @ songdetailView.js:63
Ci @ react-dom.production.min.js:2823
Zi @ react-dom.production.min.js:3347
eo @ react-dom.production.min.js:3507
Ao @ react-dom.production.min.js:4486
Mo @ react-dom.production.min.js:4505
pa @ react-dom.production.min.js:4826
ca @ react-dom.production.min.js:4800
va @ react-dom.production.min.js:5202
On @ react-dom.production.min.js:1737

Desktop (please complete the following information):

sandiz commented 5 years ago

hi @JustinAiken , was this a local release build ? can you check if your .app's ncvxrl.json has the api keys for yt and lfm ?

/Applications/Rocksmith\ Manager.app/Contents/Resources/app/ncvxrl.json

JustinAiken commented 5 years ago

Oops, that was it! Was using a locally built one.

..although; should probably not crash if youtube or lfm is down/unavailable..

sandiz commented 5 years ago

i'll add a safety check so it doesnt crash when keys are missing.

I also added you as a collaborator to the project so you should be able to see the api keys in https://travis-ci.com/sandiz/rs-manager/settings

let me know if travis doesnt allow access to rs-manager (feel free to make builds, merge pr etc 😊)

thanks for all the help justin!