2.4 breaks "Refresh Stats" button

sandiz / rs-manager

Stats Manager for Rocksmith - Manage Playlists, Stats, Setlists and more!

https://sandiz.github.io/rs-manager/

GNU General Public License v3.0

52 stars 8 forks source link

2.4 breaks "Refresh Stats" button #83

Closed JustinAiken closed 5 years ago

JustinAiken commented 5 years ago

Describe the bug

When hitting "Refresh Stats from Profile", I get this error:

Screen Shot 2019-10-03 at 3 53 18 PM

and the new Toast thing spins forever:

Screen Shot 2019-10-03 at 3 53 14 PM

To Reproduce

Be on the just released version
Hit said button

Expected behavior

Toasty notification should talk about how fast it's importing things :D

Desktop (please complete the following information): Mac OS

sandiz commented 5 years ago

looking.. thanks for the report

JustinAiken commented 5 years ago

Here's a better stacktrace from running it in dev mode instead of the packaged .dmg:

Screen Shot 2019-10-03 at 4 03 20 PM

sandiz commented 5 years ago

pushed a fix and started a build... looks like the key may or may not be there so i added a bunch of checks to all the stats refresh routines.. let me know if it works 😇

JustinAiken commented 5 years ago

No luck looks like 😞

Now it's Unhandled Rejection (TypeError): Cannot use 'in' operator to search for 'TimeStamp' in undefined

Screen Shot 2019-10-03 at 4 16 23 PM

sandiz commented 5 years ago

oh! added a null/undefined check in bbd816b2, give that a go when you get a chance!

JustinAiken commented 5 years ago

That works!

...and is speeeedy! 🚀