Adds support for Next.JS and Gatsby

sandoche / Darkmode.js

🌓 Add a dark-mode / night-mode to your website in a few seconds

https://darkmodejs.learn.uno

MIT License

2.73k stars 175 forks source link

Adds support for Next.JS and Gatsby #17

Closed aleccool213 closed 5 years ago

aleccool213 commented 5 years ago

Simply adds a flag to not run the code when window is not defined
This is a crude, simple solution that is not elegant
- Likely a better solution to this
This is just to get it working for my personal blog which uses GatsbyJS
I have not tested with Next.JS

sandoche commented 5 years ago

Have you tried to replace window with this ? It should work according to @frencojobs https://github.com/sandoche/Darkmode.js/issues/15#issuecomment-516090228

aleccool213 commented 5 years ago

@sandoche No, I read that and wasn't convinced that is the correct solution. Do you have any insight into why that would be better? IS_BROWSER is very clear to the reader.

sandoche commented 5 years ago

Why did you change the linting rules ?

aleccool213 commented 5 years ago

@sandoche Sorry about that! I accidentally committed it. I pushed up my changes without the eslint changes.

adithwip commented 5 years ago

Been waiting for this PR to merge 😅

sandoche commented 5 years ago

Yes sorry I didn't have the time yet. I will check this out this weekend!

sandoche commented 5 years ago

@adithwip Branch finally merged! @aleccool213 THanks for this amazing fix!

adithwip commented 4 years ago

Amazing! Thanks for the fix @aleccool213 And thanks for this marvelous project @sandoche