search

sandra-sherif / The-Challenger

1 stars 0 forks source link

As a user I should be able to view my profile #17

Open marinaeldib opened 9 years ago

marinaeldib commented 9 years ago

Review this @sandra-sherif @amr-nafie @seifmeligy @christianne-iskandar

amr-nafie commented 9 years ago

Scenario review approved

amr-nafie commented 9 years ago

Review Test: Missing View Tests, but model and controller tests are working fine.

sandra-sherif commented 9 years ago

Please recheck your controller and model on the following basis

  1. def and end have the same indentation
  2. after the class there is a blank space
  3. After the documentation of every def there are no blank spaces
  4. Every if and corresponding end should be indented on the same level
  5. before the end of the class there is always a blank space
  6. if the documentation does not belong to the method after it or it is just a comment please leave a blank line before and after it

Thank you

christianne-iskandar commented 9 years ago

the sequence diagram is not 100% correct

sandra-sherif commented 9 years ago

approved code review