search

sandra-sherif / The-Challenger

1 stars 0 forks source link

As a user I should be able to share a video on facebook #27

Open amr-nafie opened 9 years ago

amr-nafie commented 9 years ago

@marinaeldib @seifmeligy @sandra-sherif please review my code!

marinaeldib commented 9 years ago

Review Test: No test needed

sandra-sherif commented 9 years ago

Please recheck your controller on the following basis

  1. def and end have the same indentation
  2. after the class there is a blank space
  3. After the documentation of every def there are no blank spaces
  4. Every if and corresponding end should be indented on the same level
  5. before the end of the class there is always a blank space
  6. if the documentation does not belong to the method after it or it is just a comment please leave a blank line before and after it

Thank you

amr-nafie commented 9 years ago

@christianne-iskandar please review my diagrams

christianne-iskandar commented 9 years ago

no diagram is available but approved because only a button is needed to share it on facebook