search

sandra-sherif / The-Challenger

1 stars 0 forks source link

As a user i should be able to sign up, sign in & sign out #28

Open HayaBorham opened 9 years ago

HayaBorham commented 9 years ago

@amr-nafie @sandra-sherif @marinaeldib @christianne-iskandar please review my code.

amr-nafie commented 9 years ago

Scenario review approved

marinaeldib commented 9 years ago

Shared tests are working fine, not all tests are available. Tests review approved

sandra-sherif commented 9 years ago

Please recheck your controller and model on the following basis

  1. def and end have the same indentation
  2. after the class there is a blank space
  3. After the documentation of every def there are no blank spaces
  4. Every if and corresponding end should be indented on the same level
  5. before the end of the class there is always a blank space
  6. if the documentation does not belong to the method after it or it is just a comment please leave a blank line before and after it

Thank you