Open brandonscript opened 1 year ago
@brandonscript Same here like in #248: PHP 8.1 handles some things more strict. This is an external reference where I can't do much without having the possibility of a truncated value or updating the external reference.
Try to do that someday, but for now this is tricky since I'm using this library in many of my smaller side projects and the impact would be too big.
Another hint: --max-chapter-length
uses milliseconds, so --max-chapter-length=15,30
would result in chapters being 15ms - 30ms... maybe this results in the error?!
I'm running this via the
auto-m4b
Docker container, and in several cases I'm getting:I figured this was related to looking for chapter silence with
--max-chapter-length=15,30
but oddly I've tried without this option entirely and it still seems to crop up.Best I can tell it's related not to line 61 (there's nothing there) but to one of the
TimeUnit
ormillisecond()
calls there – looking at https://github.com/sandreas/php-time/blob/master/src/Sandreas/Time/TimeUnit.php, it looks like it's supposed to handle both float and int values, but since this is compiled running in Docker, I don't really know how to test or troubleshoot. If anyone can tell at a glance what might be going on, or suggestions on debugging, please let me know.Past that, I'm not sure if this is philosophically a bug in
TimeUnit
, or whether the values should just be rounded to ints in SilenceParser source here, like: