sandreas / tone

tone is a cross platform audio tagger and metadata editor to dump and modify metadata for a wide variety of formats, including mp3, m4b, flac and more. It has no dependencies and can be downloaded as single binary for Windows, macOS, Linux and other common platforms.
https://pilabor.com
Apache License 2.0
410 stars 17 forks source link

ChptFmtNative needs more info #30

Closed AncientAbysswalker closed 1 year ago

AncientAbysswalker commented 1 year ago

There is not currently enough info to understand how to add chapters to the Metadata. The documentation states that all that is required is the command tone tag --taggers="ChptFmtNative" [file] and the chapter data found in chapters.txt (assumedly in the same directory that the [file] is in - but I also tried the current directory and the user home directory) will be added. There is no indication of what format or interface to use. After reading through your tests it seems that the format to use is something like 00:00:00.000 chapter 1 \n00:00:05.000 chapter 2 \n00:00:15.000 chapter 3. This should be indicated. Despite this, it doesn't make any changes and simply states unchanged: [file], and does not give any indication whether the file was picked up or not. More information should be added to the documentation to make this process much clearer... I have also tried adding the --debug flag and changing the name of the chapters file and nothing changes.

Using: Windows 10 and Powershell

sandreas commented 1 year ago

Thank you for reporting this issue - I'm always especially interested in documentation problem reports, because this is something, everyone can benefit from.

Let's see if I can break down your problems into bullet points to get a better overview:

The todo's:

And now how it works:

If this does not work as expected, please feel free to give feedback.

AncientAbysswalker commented 1 year ago

Thanks for the quick response! I believe you are 100% correct in that I misunderstood the workflow due to the lack of documentation on the feature. I tested out the feature using the updated information you provided and I was able to successfully add chapters as intended! :) I believe those listed updates to the documentation should be enough to clarify the workflow.

On a side note, I think that --format=chptfmtnative is not available to me yet, as the comments in the commit seem to indicate version 0.1.1 release and I think the most recent release for Windows is 0.1.0 :)

sandreas commented 1 year ago

On a side note, I think that --format=chptfmtnative is not available to me yet, as the comments in the commit seem to indicate version 0.1.1 release and I think the most recent release for Windows is 0.1.0 :)

Ah sorry, yes, it's in the upcoming 0.1.1 - but I'm happy you solved your problem. The docs will be updated for 0.1.1, too. Thank you again for reporting this.