search

sandro / specjour

distributed rspec & cucumber via bonjour
MIT License
212 stars 33 forks source link

Option to rerun failures #34

Closed greis closed 5 years ago

greis commented 12 years ago

Added an option to auto rerun failures locally:

specjour -r

This is good for projects with a lot of random failures.

sandro commented 12 years ago

Good idea. It looks like you're having the printer rerun the failing tests, but I don't believe that's the printer's responsibility. I've thought of adding this feature myself wherein I envisioned the failing tests being redistributed among the workers. The worker would need to tell the printer to add a failing test to a rerun list. The tricky part is making sure that a test is only rerun once. What do you think?

greis commented 12 years ago

One of the reasons for random failures, is that the machine is under high load and the tests sometimes start to get timeout. If we rerun the failures within the workers we could have random failures again. That's why the printer was running the tests locally. But you are right, it is not the printer's responsibility to rerun the failures. I will rework on your suggestion to make the workers run the failures again.

greis commented 12 years ago

I made the changes, what do you think? https://github.com/greis/specjour/tree/rerun