search

sandrocardoso86 / webgrind

Automatically exported from code.google.com/p/webgrind
Other
0 stars 0 forks source link

newline in breakdown-box title is not valid #15

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago 
since the newline in the title of the breakdown box is not valid HTML; it
isn't rendered by my browser either. I suggest the following patch to be
applied. For the bars to remain; the colors should probably be made
transparent.

Original issue reported on code.google.com by Sjon.Hor...@gmail.com on 9 Jul 2008 at 10:25

Attachments:

GoogleCodeExporter commented 8 years ago 
Although the linebreak is uncommon, I can't find any reference to it being 
invalid markup. Modern browsers like 
IE5+, Firefox and Safari renders it correctly. 

The w3 validator seems to be fine with the linebreaks, but it could just be 
their parser ignoring it.

Original comment by gugakf...@gmail.com on 9 Jul 2008 at 2:28

GoogleCodeExporter commented 8 years ago 
I don't know how you tested that; but I can't get the current contruction; 
where \n
is put in the title; working in IE6 / IE 7 / Firefox3 or Safari 3

Original comment by Sjon.Hor...@gmail.com on 9 Jul 2008 at 3:26

GoogleCodeExporter commented 8 years ago 
I have just tested in safari 3 and ie6 without being able to reproduce the 
problem. 
Strange. Do you have any more information you could supply, screenshots for 
instance?

Original comment by oett...@gmail.com on 12 Jul 2008 at 4:15

GoogleCodeExporter commented 8 years ago 
Safari & IE work indeed; but Firefox3 on Linux/mac doesn't

I think the specifications, which are not very clear, can be found here:
http://www.w3.org/TR/REC-xml/#AVNormalize

Original comment by Sjon.Hor...@gmail.com on 14 Jul 2008 at 9:29

GoogleCodeExporter commented 8 years ago 
Yep, you are right. It is not working in firefox 3. We will look into it.
Thank you for the report.

Original comment by oett...@gmail.com on 14 Jul 2008 at 3:09

GoogleCodeExporter commented 8 years ago 
If I read the specification correctly, it does not say that a linebreak is 
invalid but that they must be converted to a 
single line feed character. 
In any case, it doesn't work in Firefox so I've changed the wording in r127.

Original comment by gugakf...@gmail.com on 17 Jul 2008 at 1:36

GoogleCodeExporter commented 8 years ago

Original comment by gugakf...@gmail.com on 28 Jul 2008 at 10:52