[Feature request] remember last items

[roya0045]

Greetings,

In the PR that I made I recalled that some elements remained saved, now in the latest release those elements reset. Could it be possible to have those elements remain whenever the plugin is reopened.

I don't recall how to cache them or what is causing them to reset but resetting the output each time along with other parameters is more annoying as our use case require to only need to change 1 or two element between each export.

Thanks again,

[sandroklippel]

Do you remember which elements? I didn't see these changes in PR. I'll revise it as soon as possible.

Em qui., 8 de out. de 2020 às 12:20, Alex notifications@github.com escreveu:

Greetings,

In the PR that I made I recalled that some elements remained saved, now in the latest release those elements reset. Could it be possible to have those elements remain whenever the plugin is reopened.

I don't recall how to cache them or what is causing them to reset but resetting the output each time along with other parameters is more annoying as our use case require to only need to change 1 or two element between each export.

Thanks again,

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/sandroklippel/qgis_gee_data_catalog/issues/3, or unsubscribe https://github.com/notifications/unsubscribe-auth/AIBSMEHUQRCFC24YFYDGOSTSJXKE5ANCNFSM4SI4XYJQ .

[roya0045]

I'm not sure how it happened. I've looked at your fixes and nothing stands out. An option to remember the last directory would be to store the variable in the plugin instance and not the dialog instance. Just by changing https://github.com/sandroklippel/qgis_gee_data_catalog/blob/6e5d89240ebb68d0f16620542c2aabf59e1a09a2/qgis_gee_data_catalog_dialog_base.py#L90 and adding a check if the folder variable is set before providing the default.

Or maybe it was a thing I changed and I opted to don't remember it as users had no way to 'reset' the variable (but any invalid folder would cause a temporary output to be created).

I can do a PR and some tests if you don't want or hhave the time to do so. I may have enough time during the weekend.

[sandroklippel]

Sorry, it was my fault. Just comment out line 431 in qgis_gee_data_catalog.py

Em qui., 8 de out. de 2020 às 18:17, Alex notifications@github.com escreveu:

I'm not sure how it happened. I've looked at your fixes and nothing stands out. An option to remember the last directory would be to store the variable in the plugin instance and not the dialog instance. Just by changing https://github.com/sandroklippel/qgis_gee_data_catalog/blob/6e5d89240ebb68d0f16620542c2aabf59e1a09a2/qgis_gee_data_catalog_dialog_base.py#L90 and adding a check if the folder variable is set before providing the default.

Or maybe it was a thing I changed and I opted to don't remember it as users had no way to 'reset' the variable (but any invalid folder would cause a temporary output to be created).

I can do a PR and some tests if you don't want or hhave the time to do so. I may have enough time during the weekend.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/sandroklippel/qgis_gee_data_catalog/issues/3#issuecomment-705828392, or unsubscribe https://github.com/notifications/unsubscribe-auth/AIBSMEGUKJU7YTH23WMXHJTSJYT5XANCNFSM4SI4XYJQ .

[sandroklippel]

I just commited the fix. If you can do some testing, maybe we can release a minor version after the weekend.

[roya0045]

Excellent, thanks! We'll try to do some testing today.

[roya0045]

Did a quick test, all seemed fine, the last folder string remained and the output was constant. Thanks again Sandro!

[sandroklippel]

Issue fixed, version 0.4.1 released.

[roya0045]

Thanks Sandro for the great support!