sandstone-mc / sandstone

Sandstone | Next Generation Framework for Minecraft
https://sandstone.dev/
MIT License
173 stars 16 forks source link

`onConflict` config option does not apply to implicitly created functions #124

Open GrantGryczan opened 2 years ago

GrantGryczan commented 2 years ago

Practical example:

image

image

image

image

TheMrZZ commented 2 years ago

This is actually a non-trivial problem. To fix it correctly, the "implicitely created function" should take the conflict strategy of its parent, or the general one. However, I'd need to rewrite some critical parts of Sandstone (this is planned anyway). But I won't take that risk.

Therefore, I fixed it partially: it will always default to the general strategy if it is "throw", "replace", "ignore" or "warn", but it won't take the conflict strategy of the parent.