search

sandstone-mc / sandstone

Sandstone | Next Generation Framework for Minecraft
https://sandstone.dev/
MIT License
174 stars 15 forks source link

Advancement criteria conditions have incorrect types for the `player` and `entity` properties #147

Closed GrantGryczan closed 1 year ago

GrantGryczan commented 2 years ago

The player property of any applicable advancement trigger's conditions should always accept an EntityCriterion, not only an array of predicates.

image

The player property also should not accept a single predicate that isn't in an array, which it does.

image

Additionally, the entity property of any applicable advancement trigger's conditions should always accept an array of predicates, not only an EntityCriterion.

Example advancement trigger from Minecraft wiki:

image