Add less verbose options to Score

sandstone-mc / sandstone

Sandstone | Next Generation Framework for Minecraft

https://sandstone.dev/

MIT License

173 stars 16 forks source link

Add less verbose options to Score #92

Closed ncfumction closed 3 years ago

ncfumction commented 3 years ago

This pull request adds alternatives to verbose methods of Score. For example, Score.greaterOrEqualThan can be replaced by Score['>='].

ncklwse commented 3 years ago

While this would be a breaking change, I think Score.greaterOrEqualThan and Score.lessOrEqualThan should be changed to Score.greaterThanOrEqualTo and Score.lessThanOrEqualTo respectively.

Idk it's probably not a necessary change, but it was just something that annoyed me lol

TheMrZZ commented 3 years ago

@ncklwse Feel free to write a PR to rename the methods. I will merge it for the next major version.

What's funny is I already added those short operators, but I removed them since I found they actually hurt readability. But according to the reacts, I guess people like that, so I'll merge it.