search

sandstorm-io / sandstorm

Sandstorm is a self-hostable web productivity suite. It's implemented as a security-hardened web app package manager.
https://sandstorm.io
Other
6.72k stars 705 forks source link

Hover titles missing for some top nav items #1505

Closed neynah closed 8 years ago

neynah commented 8 years ago

Discovered to be inconvenient in user testing. I propose to be consistent and add hover text to the following top bar items (that are missing hover titles):

uifix-hovertext

zarvox commented 8 years ago

Notes to self: this is made awkward by the fact that when you provide sandstorm-ui-topbar a popup template, it owns the button (and the callback to show the template), but if you don't, then you render the button yourself.

A better approach might be pushing the DOM for the button down into the component's template itself, which would allow the component to specify the button hovertext there with the button itself.

zarvox commented 8 years ago

This will want to wait until my powerbox changes are in, since they'll conflict for the Powerbox button templates. But I'll take care of this soon thereafter.