sandstorm-io / sandstorm

Sandstorm is a self-hostable web productivity suite. It's implemented as a security-hardened web app package manager.
https://sandstorm.io
Other
6.73k stars 707 forks source link

BIND_IP should apply to sandcats UDP & HTTPS requests #2508

Open paulproteus opened 8 years ago

paulproteus commented 8 years ago

Context:

Plan:

Other possible plans:

paulproteus commented 8 years ago

@kentonv curious for your +1/-1 on the above plan.

kentonv commented 8 years ago

I guess this could conceivably go wrong if someone has configured a reverse proxy to sit in front of their server and therefore configured Sandstorm to listen on localhost only. I think this case could be handled by not using BIND_IP if it is in 127.0.0.0/8 -- clearly, using it in this case wouldn't work anyway.

Other than that case, this seems like clearly the right thing to do.

The two alternate plans both seem like the wrong solution to me, and overcomplicated in any case.

gpl34 commented 7 years ago

Is there a milestone or an idea of date resolution for this item? Thank you.

paulproteus commented 7 years ago

Hi @gpl34 ,

There isn't at the moment. I suspect that's not the answer you were looking for, but at least it is an answer. :)

Hope that helps! Let me know if you have any other questions.

gpl34 commented 7 years ago

Hi @paulproteus No, it's ok, it was just to be sure the problem was not going off radar. :-) Thank you!