search

sandstorm-io / sandstorm

Sandstorm is a self-hostable web productivity suite. It's implemented as a security-hardened web app package manager.
https://sandstorm.io
Other
6.74k stars 706 forks source link

Redundancy of "was: Untitled Wekan board" and identical titles #2520

Open neynah opened 8 years ago

neynah commented 8 years ago

When the previous grain title is "Untitled Wekan board" or [the same grain title as it currently is] I think displaying "was:" text here is redundant and adds no value. I think we should not display previous titles in cases where the title is "Untitled..." or the same title as it currently is. Curious as to what other's think. image

kentonv commented 8 years ago

I agree that if the titles match exactly the "was" shouldn't be displayed -- but I thought it did that already, so that seems to be a bug.

Regarding "Untitled...", what we should really do is prevent people from sharing a grain that starts with "Untitled...". Google Docs does this: it prompts you to choose a title before you share.

neynah commented 8 years ago

Regarding "Untitled...", what we should really do is prevent people from sharing a grain that starts with "Untitled...". Google Docs does this: it prompts you to choose a title before you share.

Yes, we should do this!

dwrensha commented 8 years ago

I agree that if the titles match exactly the "was" shouldn't be displayed -- but I thought it did that already, so that seems to be a bug.

One way something like this can happen is:

  1. Alice shares grain A with Title "first title" to Bob
  2. Bob changes the title to "second title"
  3. Alice changes the title to "second title"
  4. Bob now sees the grain as "second title (renamed from: second title)"