search

sandstorm-io / sandstorm

Sandstorm is a self-hostable web productivity suite. It's implemented as a security-hardened web app package manager.
https://sandstorm.io
Other
6.72k stars 705 forks source link

Add support for "If-*" headers to powerbox #2950

Closed mbjorkegren closed 7 years ago

mbjorkegren commented 7 years ago

Just talked with @kentonv about this. We'd like to use "If-None-Match" to enable requests that return a 304 response code. It looks like ETag in the response headers might necessary as well, if it's not there already.

zenhack commented 7 years ago

Quoting mbjorkegren (2017-06-12 14:39:37)

Just talked with @kentonv about this. We'd like to use "If-None-Match" to enable requests that return a 304 response code. It looks like ETag in the response headers might necessary as well, if it's not there already.

web-session.capnp seems to suggest that all of the necessary support is there, just a question of whether the server actually passes that information on.

kentonv commented 7 years ago

Yes, this is already supported in web-session.capnp, proxy.js, and sandstorm-http-bridge, it's only missing for outgoing Powerbox HTTP API requests, due to being missing from (the poorly-named) external-ui-view.js.

I'll implement on Saturday.