Unhandled DNS errors in newFrontendRef

sandstorm-io / sandstorm

Sandstorm is a self-hostable web productivity suite. It's implemented as a security-hardened web app package manager.

https://sandstorm.io

Other

6.72k stars 705 forks source link

Unhandled DNS errors in newFrontendRef #3388

Open zenhack opened 4 years ago

zenhack commented 4 years ago

I hit this while working on getting ttrss to use the powerbox. Right now, if you make a powerbox request for an http endpoint, and then fill in a non-existent domain, the server will throw a 500, This appears in the logs:

Exception while invoking method 'newFrontendRef' Error: getaddrinfo ENOTFOUND hiohgeogrq.gov
    at GetAddrInfoReqWrap.onlookupall [as oncomplete] (dns.js:76:26)

The browser just reports the 500 error to the user directly:

Screen Shot 2020-07-13 at 23 52 48

We should handle this more gracefully.

zenhack commented 4 years ago

(I might also put the 'bug' label on this one)