topbar is broken if you resize the window from large to small to large

sandstorm-io / sandstorm

Sandstorm is a self-hostable web productivity suite. It's implemented as a security-hardened web app package manager.

https://sandstorm.io

Other

6.76k stars 706 forks source link

topbar is broken if you resize the window from large to small to large #598

Open dwrensha opened 9 years ago

dwrensha commented 9 years ago

I see this behavior in Chrome but not Firefox.

kentonv commented 9 years ago

AFAICT this is a bug in Chrome. There is no javascript executing -- everything is CSS-based -- so resizing should have no side-effects. I'm not sure what to do about it, but I think this is probably rare to see in regular usage.

paulproteus commented 9 years ago

FWIW I see this consistently now.

kentonv commented 9 years ago

https://code.google.com/p/chromium/issues/detail?id=514521

paulproteus commented 9 years ago

:heart: !

dwrensha commented 9 years ago

Chromium claims to have fixed this: https://code.google.com/p/chromium/issues/detail?id=411256, but I'm still seeing the bad behavior, as of Chrome Version 46.0.2490.80.

paulproteus commented 9 years ago

I still see this problem in my Debian chromium: 46.0.2490.71-1

But in a Chrome dev channel build, it seems fixed. Partial version details from chrome://version/

Google Chrome   48.0.2547.0 (Official Build) dev (64-bit)
Revision    625f6c8cd6bda5cd7a5b1691376956bb8f300785-refs/heads/master@{#356202}
OS  Linux 
Blink   537.36 (@625f6c8cd6bda5cd7a5b1691376956bb8f300785)

rchrd2 commented 9 years ago

This also happens in Safari, fwiw.

paulproteus commented 9 years ago

Oh man. If it also happens in Safari, then our current strategy of "Wait for everyone to auto-update to a non-broken Chrome build" is probably not going to cut it.

kentonv commented 9 years ago

I swear I tested this in safari at the time...

paulproteus commented 9 years ago

Fascinatingly if I uncheck float: right; within the CSS of the affected elements, and then check that box, the elements figure out where to put themselves. Specifically I unchecked:

@media (min-width: 901px)
body > .topbar > .menubar > .account {
    float: right;

and

@media (min-width: 901px)
body > .topbar > .menubar > .notifications {
    float: right;

within the Chromium DOM inspector, then checked the boxes again, and they figure out what to do.

dwrensha commented 9 years ago

I can reproduce this in Safari "Version 9.0.1 (10601.2.7.2)". It seems to only happen when a grain is currently open and being viewed. For example, if you are at /apps then you can resize the window without any problems.

neynah commented 8 years ago

Can we close this issue now or is it still persisting?

kentonv commented 8 years ago

Yeah this chrome issue is long-gone.

zarvox commented 8 years ago

Reopening; had a verbal report of this issue in Webkit from someone at the meetup last night.

We should switch to using flexbox for the menubar.

dwrensha commented 8 years ago

Still appears to be broken in Safari for me. :( Version 9.0.3 (11601.4.4)

dwrensha commented 8 years ago

Still a problem in Safari 10.0.