Using Sandstorm's "Share" button should add whatever trailing URL parameters are present currently - Githubissues

sandstorm-io / sandstorm

Sandstorm is a self-hostable web productivity suite. It's implemented as a security-hardened web app package manager.

https://sandstorm.io

Other

6.74k stars 705 forks source link

Using Sandstorm's "Share" button should add whatever trailing URL parameters are present currently #642

Open paulproteus opened 9 years ago

paulproteus commented 9 years ago

Steps to reproduce:

Visit https://demo.sandstorm.io/demo and click Start the demo
Click "Install apps"
Install MediaWiki
Create a new MediaWiki
Click on "Recent Changes" in the left sidebar
Notice you are at a URL like https://demo.sandstorm.io/grain/3sR92MGxkaFaMHAdQek54Y/Special:RecentChanges
Decide that you want to share this URL with a friend
Click Share and click Create to make a link

Expected results:

The sharing link is a link to the specific page I was looking at, e.g. https://demo.sandstorm.io/shared/Vfb61nczGmNRRy1VuwgQ8Z_1GbeQpQyZ4LTCkls5Y2N/Special:RecentChanges

Actual results:

The sharing link is a link to the front page, e.g. https://demo.sandstorm.io/shared/Vfb61nczGmNRRy1VuwgQ8Z_1GbeQpQyZ4LTCkls5Y2N

Note:

Until this bug is fixed, some kinds of apps that expect to store information in the URL (e.g. a pastebin) will be very sad, and a thing with multiple documents or section headings will also be sad. (I believe @larjona's Framadate package is blocked on this.)

timmc commented 3 years ago

Adding on to this, it would be great if the URL fragment would be included as well. For example, this Lychee URL includes the album ID: .../#1

The default sharing URL would go instead to the root of the grain, requiring the viewer to click on the album: .../

(Theoretically, I should be able to link to a specific image this way using .../#1/15122496781091, but the packaged version of Lychee fails to load up the actual image. Separate bug, there.)