sandstorm-io / sandstorm

Sandstorm is a self-hostable web productivity suite. It's implemented as a security-hardened web app package manager.
https://sandstorm.io
Other
6.74k stars 707 forks source link

"Who has access" information can show "null (you)" as one's name, which is odd #679

Closed paulproteus closed 8 years ago

paulproteus commented 9 years ago

Steps to reproduce:

Expected behavior:

Actual behavior:

Screenshots to reproduce, fwiw:

01-logged-in-as-alic

02-have-acronymy-shared

03-see-myself-as-null

I'm filing this bug mostly because it suggests to me we'd do well to some kind of anti-null-in-strings defensive programming pattern in Javascript to save us from issues like this. I don't know what that would be yet, but wanted to document this issue to see if code style guidelines could help.

kentonv commented 9 years ago

So, sandstorm-db/profile.js now contains code which builds a full profile out of the information we've obtained from other services. It will do things like fall back to github username if github name isn't available. Perhaps we should do a migration that applies this logic to existing profile objects, such that they all become "initialized" without the need to execute this profile-building logic at runtime?

We are also planning a first-login splash screen which will let the user explicitly set their name and such (and agree to the terms / privacy policy).