search

sandstorm-io / sandstorm

Sandstorm is a self-hostable web productivity suite. It's implemented as a security-hardened web app package manager.
https://sandstorm.io
Other
6.71k stars 704 forks source link

Audio persists after BrowserQuest tab closure #778

Open ocdtrekkie opened 9 years ago

ocdtrekkie commented 9 years ago

This feels like a Sandstorm issue because Sandstorm should kill audio feeds from closed grains.

Also, https://github.com/dwrensha/browserquest should probably have issues turned on.

dwrensha commented 9 years ago

Also, https://github.com/dwrensha/browserquest should probably have issues turned on.

Done.

dwrensha commented 9 years ago

@ocdtrekkie: which browser? The audio successfully stops for me on Firefox.

ocdtrekkie commented 9 years ago

I am testing on Edge (it didn't sound like anyone on Sandstorm team was testing Edge, so I figured it'd be fun!). It stopped for me one time, but two times it did not. I recall someone also reporting this in IRC at one point but no bug got filed anywhere?

kentonv commented 9 years ago

We observed this problem in IE11 as well, but we don't know how to fix it. :/ IE seems to be continuing to render iframes that no longer exist. Or at least failing to end audio streams that no longer have a frame playing them.

Probably not going to be fixed for launch, but we'll look into it more eventually...

ocdtrekkie commented 9 years ago

Thankfully very few Sandstorm apps currently implement background music. :)